-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove HAS controllers #481
Conversation
johnmcollier
commented
Jun 3, 2024
- Removes HAS controllers as outlined in https://issues.redhat.com/projects/DEVHAS/issues/DEVHAS-647
- Removes packages that are now unused
- Removes CDQ go module
- Removes pact tests
- Removes obsolete github actions
- Removes the tini binary build from the Dockerfile
- Moves webhooks into their own package under the root of the repository
- Updates main.go to remove the controller invocations, and update webhook package
Signed-off-by: John Collier <jcollier@redhat.com>
Signed-off-by: John Collier <jcollier@redhat.com>
…e into deprecate Signed-off-by: John Collier <jcollier@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sad to see it go but
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johnmcollier, maysunfaisal The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
New changes are detected. LGTM label has been removed. |
b3230ee
to
266f5eb
Compare
/retest |
Signed-off-by: John Collier <jcollier@redhat.com>
…e into deprecatehas Signed-off-by: John Collier <jcollier@redhat.com>
Quality Gate passedIssues Measures |
/retest |
4 similar comments
/retest |
/retest |
/retest |
/retest |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #481 +/- ##
===========================================
+ Coverage 80.25% 92.85% +12.59%
===========================================
Files 36 3 -33
Lines 5091 238 -4853
===========================================
- Hits 4086 221 -3865
+ Misses 799 12 -787
+ Partials 206 5 -201 ☔ View full report in Codecov by Sentry. |