Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove HAS controllers #481

Merged
merged 7 commits into from
Jun 8, 2024

Conversation

johnmcollier
Copy link
Member

  • Removes HAS controllers as outlined in https://issues.redhat.com/projects/DEVHAS/issues/DEVHAS-647
  • Removes packages that are now unused
  • Removes CDQ go module
  • Removes pact tests
  • Removes obsolete github actions
  • Removes the tini binary build from the Dockerfile
  • Moves webhooks into their own package under the root of the repository
  • Updates main.go to remove the controller invocations, and update webhook package

Signed-off-by: John Collier <jcollier@redhat.com>
Signed-off-by: John Collier <jcollier@redhat.com>
…e into deprecate

Signed-off-by: John Collier <jcollier@redhat.com>
@openshift-ci openshift-ci bot requested review from elsony and maysunfaisal June 3, 2024 14:13
@openshift-ci openshift-ci bot added the approved label Jun 3, 2024
@johnmcollier johnmcollier changed the title Deprecatehas Remove HAS controllers Jun 3, 2024
Signed-off-by: John Collier <jcollier@redhat.com>
Copy link
Member

@maysunfaisal maysunfaisal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sad to see it go but
/lgtm

Copy link

openshift-ci bot commented Jun 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnmcollier, maysunfaisal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [johnmcollier,maysunfaisal]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@maysunfaisal
Copy link
Member

/retest

Signed-off-by: John Collier <jcollier@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm label Jun 4, 2024
Copy link

openshift-ci bot commented Jun 4, 2024

New changes are detected. LGTM label has been removed.

@johnmcollier
Copy link
Member Author

/retest

Signed-off-by: John Collier <jcollier@redhat.com>
…e into deprecatehas

Signed-off-by: John Collier <jcollier@redhat.com>
Copy link

sonarqubecloud bot commented Jun 6, 2024

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@johnmcollier
Copy link
Member Author

/retest

4 similar comments
@johnmcollier
Copy link
Member Author

/retest

@johnmcollier
Copy link
Member Author

/retest

@johnmcollier
Copy link
Member Author

/retest

@johnmcollier
Copy link
Member Author

/retest

Copy link

codecov bot commented Jun 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.85%. Comparing base (9fbd016) to head (9d95f53).
Report is 14 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #481       +/-   ##
===========================================
+ Coverage   80.25%   92.85%   +12.59%     
===========================================
  Files          36        3       -33     
  Lines        5091      238     -4853     
===========================================
- Hits         4086      221     -3865     
+ Misses        799       12      -787     
+ Partials      206        5      -201     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johnmcollier johnmcollier merged commit 338ad7f into redhat-appstudio:main Jun 8, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants