Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

application-service update #2517

Merged
merged 9 commits into from
Oct 13, 2023
Merged

application-service update #2517

merged 9 commits into from
Oct 13, 2023

Conversation

@thepetk
Copy link
Contributor

thepetk commented Oct 10, 2023

/retest

@thepetk thepetk requested a review from kim-tsao October 11, 2023 10:21
@thepetk
Copy link
Contributor

thepetk commented Oct 11, 2023

@kim-tsao I've assigned you as reviewer as it was mentioned in the process. I have tried to retest but I couldnt

Copy link
Contributor

@kim-tsao kim-tsao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member

@johnmcollier johnmcollier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Oct 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnmcollier, kim-tsao, rh-tap-build-team[bot]

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@johnmcollier
Copy link
Member

/retest

@openshift-ci openshift-ci bot merged commit d4abfcc into main Oct 13, 2023
jhutar pushed a commit to jhutar/infra-deployments that referenced this pull request Nov 22, 2023
* update components/has/base/kustomization.yaml

* update components/has/production/kustomization.yaml

* update components/has/staging/kustomization.yaml

* update components/monitoring/grafana/base/dashboards/has/kustomization.yaml

---------

Co-authored-by: rh-tap-build-team[bot] <127938674+rh-tap-build-team[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
jhutar pushed a commit to jhutar/infra-deployments that referenced this pull request Nov 22, 2023
* update components/has/base/kustomization.yaml

* update components/has/production/kustomization.yaml

* update components/has/staging/kustomization.yaml

* update components/monitoring/grafana/base/dashboards/has/kustomization.yaml

---------

Co-authored-by: rh-tap-build-team[bot] <127938674+rh-tap-build-team[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants