application-service update

[rh-tap-build-team]

Included PRs:

• Rework replica logic application-service#427
• [DEVHAS-546] Manage build-nudges fields when Component is deleted application-service#428
• [DEVHAS-492] Test for Component Devfile with Private Parent references application-service#426
• [DEVHAS-553] Add SPI FCR test checks for Component controller application-service#429
• Replica fix for SEB application-service#430

[sonarqubecloud]

Please retry analysis of this Pull-Request directly on SonarCloud.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[maysunfaisal]

/retest

[maysunfaisal]

/lgtm

[kim-tsao]

/retest

[maysunfaisal]

/retest

[dheerajodha]

/test appstudio-e2e-tests

[dheerajodha]

failed on a known bug: RHTAPBUGS-1051
/test appstudio-e2e-tests

[johnmcollier]

/retest

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[maysunfaisal]

/lgtm
/retest

[dheerajodha]

failed on RHTAPBUGS-1051 3 times in a row, I'm thinking of skipping this test, if it's failing the CI consistently...
or maybe the failure is related to the content of this PR, can't say anything with surety now.
/test appstudio-e2e-tests

[dheerajodha]

/test appstudio-e2e-tests

[dheerajodha]

weirdly, every CI run consistently failed on RHTAPBUGS-1051, but other PRs are getting passed without many hurdles (just hitting a few occasional bugs). Could it be due to the content of this PR...?

[johnmcollier]

/retest

[johnmcollier]

The only change the would potentially affect snapshots and SEBs would be redhat-appstudio/application-service#427

The remaining changes are either test changes, or affect the Component webhook (whose content is not currently reflected in e2e tests)

@kim-tsao WDYT?

[kim-tsao]

The only change the would potentially affect snapshots and SEBs would be redhat-appstudio/application-service#427

The remaining changes are either test changes, or affect the Component webhook (whose content is not currently reflected in e2e tests)

@kim-tsao WDYT?

Replicas are still being set to 0
https://storage.googleapis.com/origin-ci-test/pr-logs/pull/redhat-appstudio_infra-deployments/2888/pull-ci-redhat-appstudio-infra-deployments-main-appstudio-e2e-tests/1733096391594479616/build-log.txt

 timed out waiting for deployment of a component rhtap-demo-idyp-tenant/hacbs-test-project-3sby to become ready
  Expected success, but got an error:
      <*errors.errorString | 0xc001662430>: 
      the deployment rhtap-demo-idyp-tenant/hacbs-test-project-3sby does not have the expected amount of replicas (expected: 1, got: 0)
      {
          s: "the deployment rhtap-demo-idyp-tenant/hacbs-test-project-3sby does not have the expected amount of replicas (expected: 1, got: 0)",
      }�[0m

@dheerajodha where is the test case located?
Previous QE test that was failing was here: https://github.com/redhat-appstudio-qe/hacbs-test-project/blob/main/devfile.yaml. I verified the fix for that one. Not sure what's different with this one

[kim-tsao]

The only change the would potentially affect snapshots and SEBs would be redhat-appstudio/application-service#427
The remaining changes are either test changes, or affect the Component webhook (whose content is not currently reflected in e2e tests)
@kim-tsao WDYT?

Replicas are still being set to 0 https://storage.googleapis.com/origin-ci-test/pr-logs/pull/redhat-appstudio_infra-deployments/2888/pull-ci-redhat-appstudio-infra-deployments-main-appstudio-e2e-tests/1733096391594479616/build-log.txt

 timed out waiting for deployment of a component rhtap-demo-idyp-tenant/hacbs-test-project-3sby to become ready
  Expected success, but got an error:
      <*errors.errorString | 0xc001662430>: 
      the deployment rhtap-demo-idyp-tenant/hacbs-test-project-3sby does not have the expected amount of replicas (expected: 1, got: 0)
      {
          s: "the deployment rhtap-demo-idyp-tenant/hacbs-test-project-3sby does not have the expected amount of replicas (expected: 1, got: 0)",
      }�[0m

@dheerajodha where is the test case located? Previous QE test that was failing was here: https://github.com/redhat-appstudio-qe/hacbs-test-project/blob/main/devfile.yaml. I verified the fix for that one. Not sure what's different with this one

It looks like it's here: https://github.com/redhat-appstudio/e2e-tests/blob/main/tests/rhtap-demo/rhtap-demo.go#L288
Everything looks fine with it. It sets a component replica, deploys and waits for the status. The SEB controller calls GetResourceFromDevfile and replicas should default to 1 if unset. Do you see anything amiss @johnmcollier ?

[sonarqubecloud]

Please retry analysis of this Pull-Request directly on SonarCloud.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[johnmcollier]

/approve
/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnmcollier, maysunfaisal, rh-tap-build-team[bot]

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• components/has/OWNERS [johnmcollier,maysunfaisal]
• components/monitoring/grafana/base/dashboards/has/OWNERS [johnmcollier,maysunfaisal]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@rh-tap-build-team[bot]: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/appstudio-hac-e2e-tests	e6d47da	link	false	/test appstudio-hac-e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.