Add log statement when deleting SnapshotEnvironmentBinding

redhat-appstudio · Oct 18, 2023 · 7f1c859 · 7f1c859
1 parent 62f7022
commit 7f1c859
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/...udio-controller/controllers/appstudio.redhat.com/snapshotenvironmentbinding_controller.go b/...udio-controller/controllers/appstudio.redhat.com/snapshotenvironmentbinding_controller.go
@@ -126,12 +126,14 @@ func (r *SnapshotEnvironmentBindingReconciler) Reconcile(ctx context.Context, re
 		},
 	}
 	if err := rClient.Get(ctx, client.ObjectKeyFromObject(&application), &application); apierr.IsNotFound(err) {
-		err = rClient.Delete(ctx, binding)
-		if err != nil {
+
+		if err := rClient.Delete(ctx, &binding); err != nil {
 			return ctrl.Result{}, fmt.Errorf("unable to delete Binding %s in Namespace %s: %w", binding.Name, binding.Namespace, err)
 		}
+		log.Info("deleting SnapshotEnvironmentBinding because referenced Application no longer exists", "applicationName", application.Name)
 		logutil.LogAPIResourceChangeEvent(binding.Namespace, binding.Name, binding, logutil.ResourceDeleted, log)
 		return ctrl.Result{}, nil
+
 	} else if err != nil {
 		return ctrl.Result{}, fmt.Errorf("error getting Application %s associated with Binding %s in Namespace %s: %w", binding.Spec.Application, binding.Name, binding.Namespace, err)
 	}