Improve test coverage of backend pt2

[jopit]

Description:

• Add unit tests for 'reconcileRepositoryCredentialStatus' in the backend component.

Link to JIRA Story (if applicable): https://issues.redhat.com/browse/GITOPSRVCE-696

[codecov]

Codecov Report

Patch coverage has no change and project coverage change: +0.07% 🎉

Comparison is base (4a6afaf) 56.04% compared to head (d32fb5d) 56.12%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #615      +/-   ##
==========================================
+ Coverage   56.04%   56.12%   +0.07%     
==========================================
  Files         100      100              
  Lines       17596    17596              
==========================================
+ Hits         9862     9876      +14     
+ Misses       6513     6497      -16     
- Partials     1221     1223       +2     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[chetan-rns]

Looks great @jopit . I think it needs a rebase to sync with the latest main

/lgtm

[jgwest]

Looks great, thanks @jopit, and thanks @chetan-rns for reviewing!

One final request: in reconcileRepositoryCredentialStatus, the following block isn't covered, but it should just be a matter of writing a quick test to call this function with an invalid objectMeta, and verify it doesn't explode:

		log.Info(fmt.Sprintf("could not find GitopsDeploymentRepositoryCredential %s in the cluster. Skipping reconciliation.", gitopsDeploymentRepositoryCredentialCR.GetName()))
		return

[jopit]

I've made all requested changes.

[jgwest]

Perfect, thanks again @jopit!

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chetan-rns, jgwest, jopit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jgwest]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment