chore: improve test coverage.

[jparsai]

Description:

This PR is to cover deleteArgoCDApplicationOfDeletedApplicationRow function, of Cluster-agent component.

JIRA Ticket:

https://issues.redhat.com/browse/GITOPSRVCE-703

[jparsai]

/test managed-gitops-e2e-tests

[jparsai]

/test managed-gitops-e2e-tests

[Rizwana777]

@jparsai I think we can cover log errors as well in deleteArgoCDApplicationOfDeletedApplicationRow function by creating mocks similar to this #612 ?

[jparsai]

@jparsai I think we can cover log errors as well in deleteArgoCDApplicationOfDeletedApplicationRow function by creating mocks similar to this #612 ?

That is a good suggestion @Rizwana777, but unfortunately there will be a lot of effort required,
for example here https://github.com/redhat-appstudio/managed-gitops/blob/main/cluster-agent/controllers/managed-gitops/eventloop/operation_event_loop.go#L967
log message will be printed only if I get an error, but there is no way I can cause labels.NewRequirement() to fail without mocking this function as well. If I go with mocking function then it has to be done for many other functions as well.

[Rizwana777]

@jparsai I think we can cover log errors as well in deleteArgoCDApplicationOfDeletedApplicationRow function by creating mocks similar to this #612 ?

That is a good suggestion @Rizwana777, but unfortunately there will be a lot of effort required, for example here https://github.com/redhat-appstudio/managed-gitops/blob/main/cluster-agent/controllers/managed-gitops/eventloop/operation_event_loop.go#L967 log message will be printed only if I get an error, but there is no way I can cause labels.NewRequirement() to fail without mocking this function as well. If I go with mocking function then it has to be done for many other functions as well.

I agree @jparsai thank you

[jgwest]

Looks great, one final request: can we also verify that the AppProject is deleted, and/or not deleted (exists), for the test cases? (more info on cluster agent appproject behaviour is here if useful).

[jparsai]

Looks great, one final request: can we also verify that the AppProject is deleted, and/or not deleted (exists), for the test cases? (more info on cluster agent appproject behaviour is here if useful).

It is done, PTAL.

[jparsai]

/test managed-gitops-e2e-tests

[jparsai]

/test managed-gitops-e2e-tests

Failing in operation_namespace_test.go, which has no changes in this PR, hence triggering once again.

[jgwest]

LGTM, thanks @jparsai!

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jgwest, jparsai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jgwest]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment