-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve test coverage of workspace_resource_event_loop.go #649
Improve test coverage of workspace_resource_event_loop.go #649
Conversation
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Feel free to rebase, then I'll take one more quick peek and 🤞 it should be good to go.
d036415
to
98bf0c6
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #649 +/- ##
==========================================
+ Coverage 60.40% 61.01% +0.61%
==========================================
Files 100 100
Lines 17690 17713 +23
==========================================
+ Hits 10685 10807 +122
+ Misses 5790 5689 -101
- Partials 1215 1217 +2
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks again @chetan-rns!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chetan-rns, jgwest The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description:
Link to JIRA Story (if applicable):
https://issues.redhat.com/browse/GITOPSRVCE-697