Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test coverage of workspace_resource_event_loop.go #649

Merged
merged 3 commits into from
Sep 27, 2023

Conversation

chetan-rns
Copy link
Contributor

Description:

  • Refactor the larger workspace resource loop handler into smaller functions
  • Add unit tests

Link to JIRA Story (if applicable):

https://issues.redhat.com/browse/GITOPSRVCE-697

@openshift-ci openshift-ci bot requested review from jgwest and Rizwana777 September 20, 2023 08:04
@chetan-rns
Copy link
Contributor Author

/retest

@jgwest jgwest removed the request for review from Rizwana777 September 22, 2023 11:48
Copy link
Member

@jgwest jgwest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Feel free to rebase, then I'll take one more quick peek and 🤞 it should be good to go.

@chetan-rns chetan-rns force-pushed the workspace-resource-tests branch from d036415 to 98bf0c6 Compare September 25, 2023 08:23
@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Patch coverage: 88.31% and project coverage change: +0.61% 🎉

Comparison is base (6c6550a) 60.40% compared to head (98bf0c6) 61.01%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #649      +/-   ##
==========================================
+ Coverage   60.40%   61.01%   +0.61%     
==========================================
  Files         100      100              
  Lines       17690    17713      +23     
==========================================
+ Hits        10685    10807     +122     
+ Misses       5790     5689     -101     
- Partials     1215     1217       +2     
Files Changed Coverage Δ
backend/eventloop/workspace_resource_event_loop.go 84.26% <88.31%> (+54.59%) ⬆️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chetan-rns chetan-rns requested a review from jgwest September 25, 2023 08:23
Copy link
Member

@jgwest jgwest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks again @chetan-rns!

@openshift-ci openshift-ci bot added the lgtm label Sep 27, 2023
@jgwest jgwest merged commit 115d38b into redhat-appstudio:main Sep 27, 2023
13 checks passed
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chetan-rns, jgwest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants