-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor log statements to better use log context, reduce verbosity #651
Refactor log statements to better use log context, reduce verbosity #651
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jgwest The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
af617ad
to
5e8a401
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #651 +/- ##
==========================================
+ Coverage 61.06% 61.08% +0.01%
==========================================
Files 100 100
Lines 17713 17842 +129
==========================================
+ Hits 10817 10899 +82
- Misses 5682 5725 +43
- Partials 1214 1218 +4
☔ View full report in Codecov by Sentry. |
d12d8e4
to
db09f6f
Compare
db09f6f
to
ee61abf
Compare
CI failure |
LGTM @jgwest |
Description:
log.WithValues(...)
deleteDbEntry
, to move the least specific params (dbqueries, log) to the end of the function signatureLink to JIRA Story (if applicable): N/A