GitOps Service should require TLS for postgresql #653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chetan-rns
approved these changes
Sep 28, 2023
|
Is there an easy way to test this locally without RDS? |
jgwest
force-pushed
the
gitopsrvce-731
branch
from
26df139 to
80cb027
Compare
|
Rebased to latest |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #653 +/- ##
==========================================
- Coverage 61.82% 61.80% -0.02%
==========================================
Files 99 99
Lines 18086 18091 +5
==========================================
Hits 11182 11182
- Misses 5652 5656 +4
- Partials 1252 1253 +1
☔ View full report in Codecov by Sentry. |
|
/retest |
Signed-off-by: John Pitman <jpitman@redhat.com>
Signed-off-by: John Pitman <jpitman@redhat.com>
Signed-off-by: John Pitman <jpitman@redhat.com>
jgwest
force-pushed
the
gitopsrvce-731
branch
from
80cb027 to
650def1
Compare
jgwest
approved these changes
Oct 16, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chetan-rns, jgwest, jopit The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Link to JIRA Story (if applicable): https://issues.redhat.com/browse/GITOPSRVCE-731