fix: Change naming convention for RepoCred secret created in Argo CD namespace. #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jparsai
force-pushed
the
repo-secret
branch
3 times, most recently
from
c02fa6a to
d3b17e9
Compare
jgwest
requested review from
jgwest
and removed request for
keithchong and
chetan-rns
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #658 +/- ##
==========================================
- Coverage 60.94% 60.75% -0.20%
==========================================
Files 99 99
Lines 17865 17867 +2
==========================================
- Hits 10888 10855 -33
- Misses 5755 5784 +29
- Partials 1222 1228 +6
☔ View full report in Codecov by Sentry. |
jparsai
force-pushed
the
repo-secret
branch
2 times, most recently
from
1936016 to
ed68909
Compare
jgwest
approved these changes
Oct 11, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jgwest, jparsai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR is to change naming convention for Secrets created for Repository Credential in Argo CD namespace.
JIRA Ticket:
https://issues.redhat.com/browse/GITOPSRVCE-755