Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing of DT e2e test #665

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

Rizwana777
Copy link
Contributor

Description:

  • Fixed failing of e2e test by adding time interval in Eventually block

@openshift-ci openshift-ci bot requested review from jgwest and keithchong October 11, 2023 08:23
@Rizwana777 Rizwana777 force-pushed the fix-failing-of-DT-e2e-test branch from b3575bb to 1fb8442 Compare October 11, 2023 12:21
@jgwest jgwest removed the request for review from keithchong October 11, 2023 12:57
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (0f4493d) 60.87% compared to head (1fb8442) 60.84%.
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #665      +/-   ##
==========================================
- Coverage   60.87%   60.84%   -0.03%     
==========================================
  Files          99       99              
  Lines       18028    18028              
==========================================
- Hits        10975    10970       -5     
- Misses       5816     5819       +3     
- Partials     1237     1239       +2     

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jgwest jgwest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @Rizwana777!

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jgwest, Rizwana777

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jgwest jgwest merged commit f80aaa6 into redhat-appstudio:main Oct 11, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants