Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GITOPSRVCE-771: add temp overlays for debugging env webhook #677

Conversation

jgwest
Copy link
Member

@jgwest jgwest commented Oct 12, 2023

Description:

  • Create temporary overlays which have the Environment webhook enabled, so we can debug the issue by enabling that webhook on RHTAP staging (only)

Link to JIRA Story (if applicable): https://issues.redhat.com/browse/GITOPSRVCE-771

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 12, 2023

@jgwest: This pull request references GITOPSRVCE-771 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.15.0" version, but no target version was set.

In response to this:

Description:

  • Create temporary overlays which have the Environment webhook enabled, so we can debug the issue by enabling that webhook on RHTAP staging (only)

Link to JIRA Story (if applicable): https://issues.redhat.com/browse/GITOPSRVCE-771

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from jopit and keithchong October 12, 2023 04:18
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jgwest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (696f2eb) 61.78% compared to head (0c663ef) 61.80%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #677      +/-   ##
==========================================
+ Coverage   61.78%   61.80%   +0.01%     
==========================================
  Files          99       99              
  Lines       18076    18076              
==========================================
+ Hits        11169    11171       +2     
+ Misses       5654     5653       -1     
+ Partials     1253     1252       -1     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jgwest
Copy link
Member Author

jgwest commented Oct 12, 2023

Temporary YAML change only, merging w/o reviews.

@jgwest jgwest merged commit f717e18 into redhat-appstudio:main Oct 12, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants