workflows: several fixes to upload release assets (#2209)

.github/workflows/upload-release-assets.yaml

@@ -3,15 +3,13 @@ name: Upload release assets
 on:
   release:
     types: [published]
-  workflow_dispatch:
 
-env:
-  CERTSUITE_X86_64_BIN: certsuite-"${GITHUB_REF_NAME}"-x86_64
-  CERTSUITE_ARM64_BIN: certsuite-"${GITHUB_REF_NAME}"-arm64
+permissions:
+  contents: write
 
 jobs:
   upload-release-assets:
-    name: Updaload release assets
+    name: Upload release assets
     runs-on: ubuntu-22.04
     steps:
 
@@ -28,19 +26,19 @@ jobs:
           SHELL: /bin/bash
         run: |
           make build
-          mv certsuite "${CERTSUITE_X86_64_BIN}"
-          tar -cvzf "${CERTSUITE_X86_64_BIN}".tar.gz "${CERTSUITE_X86_64_BIN}"
+          tar -cvzf certsuite-${GITHUB_REF_NAME}-x86_64.tar.gz certsuite
+          rm certsuite
 
       - name: Build Certsuite binary (ARM 64)
         env:
           SHELL: /bin/bash
         run: |
           make build-darwin-arm64
-          mv certsuite "${CERTSUITE_ARM64_BIN}"
-          tar -cvzf "${CERTSUITE_ARM64_BIN}".tar.gz "${CERTSUITE_ARM64_BIN}"
+          tar -cvzf certsuite-${GITHUB_REF_NAME}-arm64.tar.gz certsuite
+          rm certsuite
 
       - name: Upload Certsuite binaries
         env:
           SHELL: /bin/bash
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-        run: gh release upload $GITHUB_REF "${CERTSUITE_X86_64_BIN}".tar.gz "${CERTSUITE_ARM64_BIN}".tar.gz
+        run: gh release upload ${GITHUB_REF_NAME} certsuite-${GITHUB_REF_NAME}-x86_64.tar.gz certsuite-${GITHUB_REF_NAME}-arm64.tar.gz