-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make galaxy.yml persistent and move out ansible.cfg #663
Make galaxy.yml persistent and move out ansible.cfg #663
Conversation
Tests will all be failing until redhat-cop/ansible_collections_tooling#33 is merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trying to figure out the cli test is failing, but looks good to me
@sean-m-sullivan fix here: redhat-cop/ansible_collections_tooling#34 |
@Tompage1994 thought you were referring to the original tooling change, rerunning. |
…page1994/tower_configuration into feature/persistent-galaxyyml
Looks like that could be working now |
or not... |
Looks like it may not be related to my changes then. |
What does this PR do?
Makes galaxy.yml persistent and moves the template out of root. Also moves ansible.cfg from root.
This makes it installable from source
How should this be tested?
-devel
appended to the version that's just been released. We need to also be sure that the galaxy.yml of the released version is correctIs there a relevant Issue open for this?
related ansible/galaxy_collection#280
Other Relevant info, PRs, etc
Required redhat-cop/ansible_collections_tooling#33 to be merged