Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make galaxy.yml persistent and move out ansible.cfg #663

Merged

Conversation

Tompage1994
Copy link
Collaborator

What does this PR do?

Makes galaxy.yml persistent and moves the template out of root. Also moves ansible.cfg from root.

This makes it installable from source

How should this be tested?

  1. Test we can install from source
  2. We will need to perform a release and ensure that the galaxy.yml remains in the repo with -devel appended to the version that's just been released. We need to also be sure that the galaxy.yml of the released version is correct

Is there a relevant Issue open for this?

related ansible/galaxy_collection#280

Other Relevant info, PRs, etc

Required redhat-cop/ansible_collections_tooling#33 to be merged

@Tompage1994
Copy link
Collaborator Author

Tests will all be failing until redhat-cop/ansible_collections_tooling#33 is merged

Copy link
Collaborator

@djdanielsson djdanielsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@sean-m-sullivan sean-m-sullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trying to figure out the cli test is failing, but looks good to me

@Tompage1994
Copy link
Collaborator Author

Trying to figure out the cli test is failing, but looks good to me

@sean-m-sullivan fix here: redhat-cop/ansible_collections_tooling#34

@sean-m-sullivan
Copy link
Collaborator

@Tompage1994 thought you were referring to the original tooling change, rerunning.

@Tompage1994
Copy link
Collaborator Author

Looks like that could be working now

@Tompage1994
Copy link
Collaborator Author

Looks like that could be working now

or not...

@Tompage1994
Copy link
Collaborator Author

Looks like it may not be related to my changes then.

@sean-m-sullivan sean-m-sullivan merged commit a7a2098 into redhat-cop:devel Aug 2, 2023
7 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants