update Analysis/README.md #90
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djdanielsson
approved these changes
Jun 15, 2023
swapdisk
reviewed
Jun 15, 2023
swapdisk
requested changes
Jun 15, 2023
roles/analysis/README.md
Outdated
| | leapp_preupg_opt | String | --no-rhsm when leapp_upgrade_type is connected | Upstream repository usage - whether to use RHSM | | ||
| | leapp_metadata_url | String | | URL to the leapp metadata, usually over https | | ||
| | leapp_enable_repos_args | String | | --enablerepo (leapp_repos_enabled) or blank | | ||
| | leapp_repos_enabled | String | satellite-client-6-for-rhel-{{ ansible_distribution_major_version | int + 1 }}-x86_64-rpms | Satellite repo for the satellite client | |
There was a problem hiding this comment.
This is not rendering correctly because of the extra | char.
There was a problem hiding this comment.
this looks to be rendering correctly from what I can tell
There was a problem hiding this comment.
Actually, looking deeper, I noticed the leapp_repos_enabled variable of String type with this default value is commented out in the code. As currently implemented, this variable is List type and default value is [].
There was a problem hiding this comment.
That is correct, it is a list, and the default is an empty list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.