Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change default for update_grub_to_grub_2 from true to false. #98

Merged
merged 2 commits into from
Jul 5, 2023
Merged

Change default for update_grub_to_grub_2 from true to false. #98

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ff6bab
Change default for update_grub_to_grub_2 from true to false.
jeffmcutter Jul 5, 2023
feb9c64
Add changelog for default_grub_upgrade_to_false.
jeffmcutter Jul 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions changelogs/fragments/default_grub_upgrade_to_false.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
minor_changes:
- Change default value for update_grub_to_grub_2 from true to false. Grub will not be upgraded by default.
...
1 change: 1 addition & 0 deletions roles/upgrade/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ The `upgrade` role is used to kick off the Leapp OS upgrade on the target host.
| set_crypto_policies | true | Boolean to define if system-wide cryptographic policies should be set after the OS upgrade |
| crypto_policy | "DEFAULT" | System-wide cryptographic to set, e.g., "FUTURE", "DEFAULT:SHA1", etc. Refer to the crypto-policies (7) man page for more information. |
| post_reboot_delay | 120 | Optional integer to pass to the reboot post_reboot_delay option. |
| update_grub_to_grub_2 | false | Boolean to control whether grub gets upgraded to grub 2 in post RHEL 6 to 7 upgrade. |

## Example playbook

Expand Down
2 changes: 1 addition & 1 deletion roles/upgrade/defaults/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ crypto_policy: DEFAULT
# crypto_policy: DEFAULT:SHA1

# Whether or not to update from legacy grub to grub2 in post-upgrade steps from RHEL 6 -> 7.
update_grub_to_grub_2: true
update_grub_to_grub_2: false

# Used by grub to grub2 upgrade in RHEL 6 to 7 post upgrade, and RHEL 7 to 8 post upgrade.
# For grub to grub2 upgrade, if grub_boot_device is not defined, the parent device of /boot
Expand Down