Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated references for OpenShift 'master' to 'control plane node' #279

Open
wants to merge 2 commits into
base: devel
Choose a base branch
from

Conversation

semlohnayr
Copy link

@semlohnayr semlohnayr commented Feb 11, 2022

Changed references from master to control plane node (or just control plane) WRT OpenShift. Fix #274

@@ -141,12 +141,12 @@ Create the installation manifests
openshift-install create manifests
```

Edit the `manifests/cluster-scheduler-02-config.yml` Kubernetes manifest file to prevent Pods from being scheduled on the control plane machines by setting `mastersSchedulable` to `false`.
Edit the `manifests/cluster-scheduler-02-config.yml` Kubernetes manifest file to prevent Pods from being scheduled on the control plane machines by setting `controlplaneSchedulable` to `false`.
Copy link

@whowutwut whowutwut Feb 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a spec change that has happened in the latest OpenShift? I think the spec name is mastersSchedulable

spec:
  mastersSchedulable: false
...

same comment applies to the other lines changed in this file.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@whowutwut oversight on my part. Reverted back to mastersSchedulable.

@christianh814
Copy link
Contributor

Sorry, I am blocked from testing any PRs until this issue is fixed

#277

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants