update README and add new screenshots #33
Conversation
|
@jeffmaury @dgolovin @benoitf PTAL |
There was a problem hiding this comment.
I reported few suggestion glitches
FYI README content is usually included in the catalog and then it's being displayed when you open special links to podman desktop
using the shortcut  won't work as it's relative links
you should update it with links starting with https://raw.githubusercontent.com/redhat-developer/podman-desktop-redhat-account-ext/main/images/...
|
|
||
| The first available Alpha image is `quay.io/redhat-developer/podman-desktop-redhat-account-ext:0.0.1-alpha.1`. |
There was a problem hiding this comment.
will it be published in the catalog ?
https://github.com/containers/podman-desktop-catalog/tree/gh-pages
about the versioning
there is a version named 0.0.1 there so it's strange to have 0.0.1 being older than 0.0.1-alpha1
then you could have links like : podman-desktop:extension/redhat.redhat-authentication that will prompt you if you have podman desktop installed to install this extension
There was a problem hiding this comment.
I will change it to 0.0.2-alpha.1
Update the README with instructions on how to install and use the extension along with some fresh screenshots. Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
Thanks! Can we do that in a follow-up PR? Otherwise, they won't show up now for review as the images are not yet uploaded/pushed. Or is there a way to do that? |
|
follow-up works for me, I just wanted to bring awareness and approved the PR |
|
Thanks for the review, @benoitf ! |
vrothberg
force-pushed
the
hackathon-subscription-vrothberg
branch
from
dfcb118
to
6dafa8c
Compare
|
@rhatdan FYI |
|
I'll take care of images in follow up PR as well |
Update the README with instructions on how to install and use the extension along with some fresh screenshots.