Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add placeholder for context name and command fields #88

Merged
merged 2 commits into from
Aug 3, 2023
Merged

feat: add placeholder for context name and command fields #88

merged 2 commits into from
Aug 3, 2023

Conversation

dgolovin
Copy link
Collaborator

@dgolovin dgolovin commented Aug 2, 2023 •
edited
Loading

Fix #53.

image

@dgolovin
feat: add placeholder for context name and command fields
13ed6dd 
Fix redhat-developer#53.

Signed-off-by: Denis Golovin <dgolovin@redhat.com>
@dgolovin dgolovin requested a review from a team as a code owner August 2, 2023 04:41
@dgolovin dgolovin requested a review from benoitf August 2, 2023 04:41
@deboer-tim
Copy link
Contributor

IMHO users understand that placeholders are sample text, e.g. we don't say Example Podman machine name: here:
Screenshot 2023-08-02 at 8 33 00 AM

Could we remove Example of context name: and Command example: from the text?

@dgolovin
fix: remove 'Example ****:' part from placeholder values
5f5abef 
Signed-off-by: Denis Golovin <dgolovin@redhat.com>
@dgolovin
Copy link
Collaborator Author

dgolovin commented Aug 2, 2023

@deboer-tim updated placeholders and screenshot

@dgolovin dgolovin merged commit 59f3209 into redhat-developer:main Aug 3, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benoitf benoitf Awaiting requested review from benoitf benoitf was automatically assigned from redhat-developer/podman-desktop

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add placeholders for the different values asked to the user
2 participants
@dgolovin @deboer-tim