Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the deployment with correct model names, requirements and image #39

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

hemajv
Copy link
Collaborator

@hemajv hemajv commented Aug 8, 2024

For our upcoming talk at DevConf we plan to use this as part of our demo. There are few things which are outdated in the current deployment and this PR addresses them as follows:

  • Updating the requirements.txt with necessary packages and versions
  • Updating the app/app.py to include additional evaluation metrics such as ROUGE score
  • Some of the IBM BAM model names have changed and hence these have been updated in app/app.py
  • All the above mentioned changes have been pushed to a new docker image docker.io/hemaveeradhi/api-docs:v0.2.0 which has also been updated to be used in the deployment.yaml

cc @suppathak

@hemajv hemajv changed the title Update the deployment with correct model names, requirements and base… Update the deployment with correct model names, requirements and image Aug 8, 2024
@hemajv hemajv requested a review from suppathak August 8, 2024 23:05
Copy link
Collaborator

@RobotSail RobotSail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@aakankshaduggal aakankshaduggal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@hemajv hemajv merged commit 3e7cdb0 into redhat-et:main Aug 9, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants