add exec.LookPath to check operator-sdk is in $PATH #1209
Merged
+14
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: acornett21 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
from change #1209: |
|
from change #1209: |
Signed-off-by: Adam D. Cornett <adc@redhat.com>
acornett21
force-pushed
the
add_operator_sdk_bin_lookup
branch
from
0e1afe7
to
7a4338a
Compare
|
from change #1209: |
|
/test 4.13-images |
|
/test 4.17-e2e |
1 similar comment
|
/test 4.17-e2e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The ux when a user does not have
operator-sdkin their path leads to a confusing error that is hard to track down.Current Error Message:
This error is not clear at all what is going on, but we do not have direct control of this once we shell out to
operator-sdkChanges
Add an explicit check to make sure that
operator-sdkbinary is in the usersPATH. This provides an error message that is more clearer.New Error Message:
Note
Since this is in the
Scorecardmethod, it does not matter which checkBasicorOlmSuitegets called, this error will appear.