-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add exec.LookPath to check operator-sdk is in $PATH #1209
add exec.LookPath to check operator-sdk is in $PATH #1209
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: acornett21 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
from change #1209: |
from change #1209: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small change
Signed-off-by: Adam D. Cornett <adc@redhat.com>
0e1afe7
to
7a4338a
Compare
from change #1209: |
/test 4.13-images |
/test 4.17-e2e |
1 similar comment
/test 4.17-e2e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Motivation
The ux when a user does not have
operator-sdk
in their path leads to a confusing error that is hard to track down.Current Error Message:
This error is not clear at all what is going on, but we do not have direct control of this once we shell out to
operator-sdk
Changes
Add an explicit check to make sure that
operator-sdk
binary is in the usersPATH
. This provides an error message that is more clearer.New Error Message:
Note
Since this is in the
Scorecard
method, it does not matter which checkBasic
orOlmSuite
gets called, this error will appear.