Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update populate registry to use file based approch #258

Conversation

nocturnalastro
Copy link
Collaborator

SQLite approch has been depricated so using the proceedure found here redhat-openshift-ecosystem/community-operators-prod#793 (comment)

@nocturnalastro
Copy link
Collaborator Author

@p3ck @thekad could you guys review this PR for me :)
it fixes issue #253

-f configs.Dockerfile
.
chdir: "{{ temp_dir.path }}"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a similar process but we also validate the pruned index something like

- name: "Validate pruned index"
  cmd: >
    {{ downloads_path }}/{{ openshift_full_version }}/opm validate configs/
  args:
    chdir: "{{ temp_dir.path }}"

Copy link
Contributor

@thekad thekad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look fine to me programmatically, I don't currently have an environment to test though.

@nocturnalastro nocturnalastro merged commit e0ae7c3 into redhat-partner-solutions:main Jul 25, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants