Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to specify a registry repository and nightlies registry #265

Conversation

manurodriguez
Copy link
Contributor

Currently the registry repository is hardcoded to the default ocp4/openshift4, this patch includes a variable to customize it, the default is still ocp4/openshift4. Also a registry entry for OCP nightlies version is included.

fixes: #264

@manurodriguez manurodriguez requested a review from a team as a code owner September 7, 2023 21:52
@dcibot
Copy link

dcibot commented Sep 11, 2023

Starting dci-check-change job.

@dcibot
Copy link

dcibot commented Sep 11, 2023

@manurodriguez
Copy link
Contributor Author

Thanks for the review @nocturnalastro
I tested the change is not breaking connected deployments, and I'm about to test in disconnected envs, I'll update with my results before merging. Thanks.

@dcibot
Copy link

dcibot commented Sep 13, 2023

Starting dci-check-change job.

Copy link
Collaborator

@arjuhe arjuhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Currently the registry repository is hardcoded to the default
ocp4/openshift4, this patch includes a variable to customize it,
the default is still ocp4/openshift4. Also a registry entry for
OCP nightlies version is included.
@dcibot
Copy link

dcibot commented Sep 13, 2023

@arjuhe arjuhe merged commit f3141df into redhat-partner-solutions:main Sep 13, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

expand disconnected mirroring registry options
4 participants