Add sync test pipeline #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
novacain1
approved these changes
Jul 21, 2023
| - ReadWriteOnce | ||
| resources: | ||
| requests: | ||
| storage: 10Gi |
There was a problem hiding this comment.
Would be interesting to understand how much storage is required in the long run, as 10Gi seems like a lot on paper with examples in tekton.dev showing 16Mb in examples.
There was a problem hiding this comment.
Good point this is way too much and not needed. This is leftover from the previous test pipeline and is not needed anymore since we take the test output.
I removed the use of workspace
novacain1
reviewed
Jul 31, 2023
|
|
||
| fi | ||
| - name: VERSION | ||
| value: '4.12' |
There was a problem hiding this comment.
Discussed this, this is the openshift-client used on the cluster running Pipelines (Tekton), for us its 4.12 for now. Something to keep in mind to put into the README in case futures require running the pipeline on 4.13+ Hub clusters.
novacain1
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.