Wander TDEV and MTIE Analyzers #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnunyez
force-pushed
the
wander
branch
4 times, most recently
from
85e7f4a
to
9074fbe
Compare
jnunyez
changed the title
jnunyez
force-pushed
the
wander
branch
2 times, most recently
from
6d779bc
to
c193655
Compare
Merged
natifridman
reviewed
Sep 26, 2023
spenced
suggested changes
Sep 26, 2023
spenced
reviewed
Sep 27, 2023
| if ((low is None or tau > low) and (tau <= high)): | ||
| return f(tau) * (self._limit / 100) | ||
|
|
||
| def out_of_range(self, taus, samples): |
There was a problem hiding this comment.
This also may be better as a regular function.
natifridman
reviewed
Sep 27, 2023
jnunyez
changed the title
jnunyez
changed the title
jnunyez
force-pushed
the
wander
branch
3 times, most recently
from
df901d6
to
d811478
Compare
jnunyez
force-pushed
the
wander
branch
2 times, most recently
from
30feafd
to
504f181
Compare
jnunyez
changed the title
spenced
approved these changes
Sep 29, 2023
| self._samples = None | ||
|
|
||
| def test(self, data): | ||
| result = super()._test_common(data) |
There was a problem hiding this comment.
Suggested change
| result = super()._test_common(data) | |
| result = self._test_common(data) |
| return result | ||
|
|
||
| def explain(self, data): | ||
| analysis = super()._explain_common(data) |
There was a problem hiding this comment.
Suggested change
| analysis = super()._explain_common(data) | |
| analysis = self._explain_common(data) |
| self._samples = None | ||
|
|
||
| def test(self, data): | ||
| result = super()._test_common(data) |
There was a problem hiding this comment.
Suggested change
| result = super()._test_common(data) | |
| result = self._test_common(data) |
| return result | ||
|
|
||
| def explain(self, data): | ||
| analysis = super()._explain_common(data) |
There was a problem hiding this comment.
Suggested change
| analysis = super()._explain_common(data) | |
| analysis = self._explain_common(data) |
|
|
||
| (a, f1), (c, f2) = REQUIREMENTS['G.8272/PRTC-A']['maximum-time-interval-error-in-locked-mode/us'].items() | ||
|
|
||
| self.assertEqual(f1(100), 0.052500000000000005) |
There was a problem hiding this comment.
0.525... is very specific, worth a comment? (For one, I'd like to understand why!)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add Time Deviation calculation for the four points of observations in the system.