Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend plotter #47

Merged
merged 8 commits into from
Oct 9, 2023
Merged

Extend plotter #47

merged 8 commits into from
Oct 9, 2023

Conversation

nocturnalastro
Copy link
Contributor

No description provided.

@jnunyez jnunyez self-requested a review October 5, 2023 18:27
@nocturnalastro nocturnalastro marked this pull request as ready for review October 6, 2023 09:46
crwr45
crwr45 suggested changes Oct 6, 2023
View reviewed changes
Copy link

@crwr45 crwr45 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the "extend plotter" commit to say why the plotter is being updated.

tests/vse_sync_pp/analyzers/test_phc2sys.py Outdated Show resolved Hide resolved
@jnunyez jnunyez force-pushed the extend_plotter branch 2 times, most recently from 4241427 to 1b000df Compare October 9, 2023 08:34
@jnunyez jnunyez self-requested a review October 9, 2023 08:36
@jnunyez
Copy link
Collaborator

jnunyez commented Oct 9, 2023

@nocturnalastro added CDF to histograms in the PR. Is this ready to get merged?

@jnunyez jnunyez requested a review from crwr45 October 9, 2023 09:59
@jnunyez jnunyez mentioned this pull request Oct 9, 2023
Merged
@nocturnalastro nocturnalastro merged commit 8e05c53 into redhat-partner-solutions:main Oct 9, 2023
2 checks passed
@nocturnalastro nocturnalastro deleted the extend_plotter branch October 9, 2023 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crwr45 crwr45 crwr45 approved these changes

@jnunyez jnunyez jnunyez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nocturnalastro @jnunyez @crwr45