-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update run workloads steps #624
Conversation
cd benchmark-runner | ||
``` | ||
|
||
4. **MUST**: Update the necessary environment variables in benchmark_runner/main/environment_variables.py, e.g., ('WORKLOAD', 'vdbench_vm'). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Modifying a file just to run a command isn't a great idea. Either set the environment variables in the environment or use command line options rather than modifying this file.
6. Run the following command in the terminal: | ||
|
||
``` | ||
PYTHONPATH=. python3 benchmark_runner/main/main.py "$@" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "$@"
is used for processing command line arguments.
Why did you delete run_workload.sh? It's simpler to run run_workload.sh
than to issue a python command line with PYTHONPATH set.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You right, see the updated code
495e8b3
to
4aa1801
Compare
benchmark_runner/jupyterlab/templates/run_workload/run_workload.sh
Outdated
Show resolved
Hide resolved
benchmark_runner/jupyterlab/templates/run_workload/how_to_run_workload.md
Outdated
Show resolved
Hide resolved
4aa1801
to
48257a2
Compare
48257a2
to
a382aaf
Compare
Fix: