Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update run workloads steps #624

Merged
merged 1 commit into from
Jul 28, 2023
Merged

update run workloads steps #624

merged 1 commit into from
Jul 28, 2023

Conversation

ebattat
Copy link
Collaborator

@ebattat ebattat commented Jul 23, 2023

Fix:

  • Update the instruction to run workload through JupyterLab terminal.

@ebattat ebattat added the ok-to-test PR ok to test label Jul 23, 2023
@ebattat ebattat self-assigned this Jul 23, 2023
RobertKrawitz
RobertKrawitz requested changes Jul 26, 2023
View reviewed changes
benchmark_runner/jupyterlab/templates/run_workload/how_to_run_workload.md Outdated
cd benchmark-runner
```

4. **MUST**: Update the necessary environment variables in benchmark_runner/main/environment_variables.py, e.g., ('WORKLOAD', 'vdbench_vm').
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modifying a file just to run a command isn't a great idea. Either set the environment variables in the environment or use command line options rather than modifying this file.

benchmark_runner/jupyterlab/templates/run_workload/how_to_run_workload.md
6. Run the following command in the terminal:

```
PYTHONPATH=. python3 benchmark_runner/main/main.py "$@"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "$@" is used for processing command line arguments.

Why did you delete run_workload.sh? It's simpler to run run_workload.sh than to issue a python command line with PYTHONPATH set.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You right, see the updated code

@ebattat ebattat removed the Approved label Jul 27, 2023
@ebattat ebattat merged commit 4b77b05 into redhat-performance:main Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobertKrawitz RobertKrawitz RobertKrawitz approved these changes

Assignees

@ebattat ebattat

Labels
ok-to-test PR ok to test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ebattat @RobertKrawitz