Skip to content

Commit

Permalink
make vnet name configurable
Browse files Browse the repository at this point in the history
Signed-off-by: mjiao <mjiao@redhat.com>
  • Loading branch information
mjiao committed Aug 20, 2024
1 parent b7a54fa commit 648e6a1
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion bicep.makefile
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ network-deploy: ## Deploy network
az deployment group create --resource-group ${ARO_RESOURCE_GROUP} \
--template-file bicep/network.bicep

.PNONY: resource-group
.PHONY: resource-group
resource-group: ## Create resource group
az group create --name ${ARO_RESOURCE_GROUP} --location ${ARO_LOCATION} --query name -o tsv

Expand Down
2 changes: 1 addition & 1 deletion bicep/network.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
//
// SPDX-License-Identifier: Apache-2.0

param vnetName string = 'aro-sapeic-vnet'
param vnetName string = '${resourceGroup().name}-vnet'
param masterSubnetName string = 'master'
param workerSubnetName string = 'worker'

Expand Down
6 changes: 3 additions & 3 deletions hack/domain-records.sh
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
# SPDX-License-Identifier: Apache-2.0

DOMAIN=""
ARO_NAME=""
ARO_CLUSTER_NAME=""
ARO_RESOURCE_GROUP=""

print_help() {
Expand All @@ -28,7 +28,7 @@ while (( "$#" )); do
shift 2
;;
--aro-name)
ARO_NAME="$2"
ARO_CLUSTER_NAME="$2"
shift 2
;;
--aro-resource-group)
Expand All @@ -41,7 +41,7 @@ while (( "$#" )); do
esac
done

if [ -z "$DOMAIN" ] || [ -z "$ARO_NAME" ] || [ -z "$ARO_RESOURCE_GROUP" ]; then
if [ -z "$DOMAIN" ] || [ -z "$ARO_CLUSTER_NAME" ] || [ -z "$ARO_RESOURCE_GROUP" ]; then
echo "Error: Missing argument"
print_help
fi
Expand Down

0 comments on commit 648e6a1

Please sign in to comment.