Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test against Redis CE #3191

Merged
merged 10 commits into from
Dec 16, 2024
Merged

Test against Redis CE #3191

merged 10 commits into from
Dec 16, 2024
+69 −3

Conversation

ofekshenawa
Copy link
Collaborator

No description provided.

@ofekshenawa ofekshenawa changed the title Add Docker Compose-Based Redis Environment for go-redis CI Test against Redis CE Dec 15, 2024
@ofekshenawa ofekshenawa marked this pull request as ready for review December 16, 2024 09:36
ggivo
ggivo reviewed Dec 16, 2024
View reviewed changes
Copy link

@ggivo ggivo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, looks good.
Left some minor questions/notes.

.github/workflows/build.yml Outdated Show resolved Hide resolved
.github/workflows/build.yml Outdated Show resolved Hide resolved
docker-compose.yml Outdated Show resolved Hide resolved
docker-compose.yml Show resolved Hide resolved
docker-compose.yml Outdated Show resolved Hide resolved
main_test.go Outdated Show resolved Hide resolved
ggivo
ggivo reviewed Dec 16, 2024
View reviewed changes
Copy link

@ggivo ggivo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ofekshenawa ofekshenawa merged commit 91dddc2 into master Dec 16, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggivo ggivo ggivo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ofekshenawa @ggivo