Added JSON.MERGE to lettucemod #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jruaux I would like to add this feature as soon as possible as its needed for bachelor thesis of mine :)) |
|
@lpawlak1 Thanks for your contribution. Unfortunately the tests (and many others in the lettucemod test suite) are not passing. I think this is due to the latest RediSearch release but I cannot find the root cause... If you have any idea please chime in |
|
I think the issue is fixed now. Can you merge your PR and I'll run the tests again |
lpawlak1
force-pushed
the
jsonMerge
branch
2 times, most recently
from
199eb41
to
2edd4a8
Compare
|
@jruaux Everything looks good now |
|
Your contribution was included in 3.7.0. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provided way to interact with Json.Merge of RedisJSON 2.6.0 :)