New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to read /etc/redis/redis.conf #4

Open

dualmi wants to merge 1 commit into redis:master from dualmi:master

dualmi commented Apr 7, 2021

Makes readable /etc/redis/redis.conf and allows to configure redis snap with it.

Additional systemd modifications requred:

Run systemctl edit snap.redis.server
Add following code to provide config path to redis executable (empty ExecStart required)

[Service]
ExecStart=
ExecStart=/usr/bin/snap run redis.server /etc/redis/redis.conf


          Update snapcraft.yaml

d293376

Member

yossigo commented Apr 13, 2021

@keir-ru Thanks for this PR, I have a few comments:

Perhaps it will be a better idea to make all of /etc/redis readable? Depending on deployment, there could be other files as well.
While at it, what about writable configuration files? For example, acl file, cluster nodes.conf, sentinel.conf or even redis.conf when CONFIG REWRITE is used.
I think it would be a good idea to update the README.md to add a section on running the snap package with systemd and include a more detailed example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet