Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sentence transformers reranker import #231

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

tylerhutcherson
Copy link
Collaborator

Sentence transformers was not being dynamically imported into the reranker module for hugging face, causing dependency issues for anyone using a reranker. Fixes #229

@tylerhutcherson tylerhutcherson added the bug Something isn't working label Oct 8, 2024
Copy link
Collaborator

@rbs333 rbs333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tylerhutcherson tylerhutcherson merged commit 3c74dee into main Oct 8, 2024
20 checks passed
@tylerhutcherson tylerhutcherson deleted the bug/RAAE-350/fix-cohere-reranker-dependency branch October 8, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cohere reranker depends on sentence_transformers
2 participants