Added image preview for HomeKey Card Finish in Misc configuration page on HomeKey Card Finish click #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! Appreciate the PR 😀 Got some thoughts on this:
Right now am working on reorganizing and refreshing the design of the webui, once done i'll rebase the PR and merge it in along with the resized the images |
|
Great. Let me know if you need any help. Happy to help. |
…e on card finish click
…iew for HomeKey Card Finish.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds image preview for HomeKey Card Finish in Misc configuration page on HomeKey Card Finish click.
gif showing the UI:
If you accept this commit then we can remove the images from littlefs and add raw links of images in code, which will free up the space.
Let me know.