Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backend: configurable maxDepth for git repositories #814

Closed
wants to merge 2 commits into from

Conversation

chorin1
Copy link

@chorin1 chorin1 commented Aug 18, 2023

  1. maxDepth for git is now configurable through:
    a. kafka:protobuf:git:repository:maxDepth
    b. kafka:console:git:repository:maxDepth
    Previously, both were hardcoded to 5 and 15 respectively.
  2. Adds units test for the above and for default configuration.

Resolves #277

chorin added 2 commits August 18, 2023 14:25
- Set default maxDepth to 15.
- Previously, markdown fetching used a hardcoded maxDepth of 15,
  while fetching proto definitions used a value of 5.
@CLAassistant
Copy link

CLAassistant commented Aug 18, 2023

CLA assistant check
All committers have signed the CLA.

@twmb
Copy link
Contributor

twmb commented Oct 19, 2023

Ping @weeco to review

@weeco
Copy link
Contributor

weeco commented Sep 22, 2024

Thanks for your contribution and sorry for the heavily delayed review. I created #814 to supersede this one.

@weeco weeco closed this Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Protobuf Git Config: BaseDirectory & Depth
4 participants