Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RS-47: manage replication in web console #62

Merged
merged 15 commits into from
Mar 1, 2024
Merged

RS-47: manage replication in web console #62

merged 15 commits into from
Mar 1, 2024

Conversation

AnthonyCvn
Copy link
Contributor

@AnthonyCvn AnthonyCvn commented Feb 28, 2024 •
edited
Loading

Closes #

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • CHANGELOG.md has been updated (for bug fixes / features / docs)

What kind of change does this PR introduce?

feature

What was changed?

This PR introduces a new view to manage replications.

Related issues

No

Does this PR introduce a breaking change?

No

Other information:

@atimin atimin changed the title Rs 47 manage replication in web console RS-47: manage replication in web console Feb 28, 2024
atimin
atimin requested changes Feb 28, 2024
View reviewed changes
Copy link
Member

@atimin atimin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Here , I can't see the reason of the errors. The API provides a map with errors. We should show it as a table. You can see how it works in the ReductCli tool.

src/App.tsx Outdated Show resolved Hide resolved
atimin
atimin requested changes Feb 28, 2024
View reviewed changes
Copy link
Member

@atimin atimin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update the favicon.I'm always forgetting to do it =')

atimin
atimin requested changes Feb 28, 2024
View reviewed changes
Copy link
Member

@atimin atimin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we use the same approach to show provisioned resources as we do for buckets and tokens?

image

@atimin atimin merged commit e87dfe3 into main Mar 1, 2024
4 checks passed
@atimin atimin deleted the RS-47-Manage-Replication-in-WebConsole branch March 1, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atimin atimin atimin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AnthonyCvn @atimin