RS-180: Web console shows license information #64
Conversation
|
@atimin I need a first review from you to check if the layout is good. I will write some tests once validated. |
There was a problem hiding this comment.
I love the idea to use a tab for the license information. Looks great for me.
Few minor remarks:
-
Expire data looks strange on my side:
-
Maybe we could use bold font for names of field:
Plan: UNLIMITED
- Don't forget that we need validation as well. See here the example:
https://github.com/reductstore/reductstore/blob/main/reduct_cli/src/io/reduct.rs#L38
|
@atimin everything should be good and tested :) Please have a look. Just a small point, I assumed the expiration date from the license to return the number of milliseconds since midnight, January 1, 1970 (UTC), I think it's the case, but just to double check. |
|
|
|
||
| return ( | ||
| <> | ||
| {alertExplanation && <div className="licenseAlert"><LicenseAlert alertExplanation={alertExplanation} /></div>} |
There was a problem hiding this comment.
I'm not sure if the mentioning of BUSL is relevant here. Maybe we could say that they must contact us to extend it.
Closes #
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
Feature
What was changed?
A tab to show the license information.
Sample license:
No license:
Usage tab:
Related issues
No
Does this PR introduce a breaking change?
Yes, it works only with reduct-js > 1.9.1
Other information:
A bug fix was needed on reduct-js to use it on the browser. Please update to reduct-js > 1.9.1 to test the web console.