Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RS-319: add downsampling options to Create/Update Replication form #69

Merged
merged 4 commits into from
Jul 2, 2024

Conversation

atimin
Copy link
Member

@atimin atimin commented Jul 1, 2024

Closes #

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • CHANGELOG.md has been updated (for bug fixes / features / docs)

What kind of change does this PR introduce?

Feature

What was changed?

Add the new fields 'Every nth record' and 'Once for seconds' to the replication settings form:

image

Related issues

No

Does this PR introduce a breaking change?

No

Other information:

@atimin atimin requested a review from AnthonyCvn July 1, 2024 15:27
Copy link
Contributor

@AnthonyCvn AnthonyCvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

@AnthonyCvn AnthonyCvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just saw a phrase to clarify

src/Components/Replication/CreateOrUpdate.tsx Outdated Show resolved Hide resolved
@atimin atimin merged commit 0bc358f into main Jul 2, 2024
5 checks passed
@atimin atimin deleted the RS-319-replication-downsampling branch July 2, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants