chore(cli): convert the cli to ESM #10409
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like we can't use |
jtoar
commented
Apr 4, 2024
| @@ -39,6 +40,8 @@ export const handler = async ({ | |||
| const useFragments = rwjsConfig.graphql?.fragments | |||
| const useTrustedDocuments = rwjsConfig.graphql?.trustedDocuments | |||
|
|
|||
| const require = createRequire(path.join(getPaths().base, 'node_modules')) | |||
There was a problem hiding this comment.
I'll probably refactor this into a helper once I have a better idea of where it's used
jtoar
commented
Apr 4, 2024
| import { timedTelemetry } from '@redwoodjs/telemetry' | ||
|
|
||
| import { getPaths, getConfig } from '../lib' |
There was a problem hiding this comment.
This is ESM-specific. Implicit imports like this (this is really '../lib/index.js') don't work
jtoar
commented
Apr 4, 2024
| @@ -693,7 +693,7 @@ export const handler = async (yargs) => { | |||
| verbose: yargs.verbose, | |||
| }) | |||
|
|
|||
| const { NodeSSH } = require('node-ssh') | |||
| const { NodeSSH } = await import('node-ssh') | |||
There was a problem hiding this comment.
This has to be tested still
Tobbe
changed the title
|
@cannikin @thedavidprice I think we should probably close this PR, I don't really see anyone picking this up and it's diverged somewhat. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR starts on getting the CLI to ESM. The CLI isn't consumed by any other packages it's just invoked so it doesn't have to be dual published.
So far most of the changes are adding file extensions and changing the way we import CJS packages. Some packages that we've told renovate to ignore because they're ESM-only may only be used by the CLI and could be upgraded to their latest versions.
The bin proxies in
@redwoodjs/corewere tricky since we can't require files from the CLI. That part I'd still like to think more about. (And theconst { ... } = pkgworkarounds.) CI will tell us if the existing strategy works on Windows.So far this is one of those PRs where, as I fix one thing, another thing comes up. It looks like I still have to deal with
require__dirnamecommandDir