(feat): Improvements

internal/config/config.go

@@ -28,10 +28,6 @@ const (
 	Force      Mode = "force"
 )
 
-func (m Mode) String() string {
-	return string(m)
-}
-
 func ParseMode(s string) (Mode, error) {
 	Modes := map[Mode]struct{}{
 		Empty:      {},

internal/model/filesystem.go

@@ -10,10 +10,6 @@ const (
 	Xfs         FileSystem = "xfs"
 )
 
-func (c FileSystem) String() string {
-	return string(c)
-}
-
 func ParseFileSystem(s string) (FileSystem, error) {
 	FileSystems := map[FileSystem]struct{}{
 		Unformatted: {},

internal/service/filesystem.go

@@ -36,20 +36,14 @@ func NewLinuxFileSystemServiceFactory(rc utils.RunnerFactory) *LinuxFileSystemSe
 }
 
 func (fsf *LinuxFileSystemServiceFactory) Select(fs model.FileSystem) (FileSystemService, error) {
-	// Check if the instance is already in the services cache
-	fss, exists := fsf.services[fs]
-	if !exists {
-		switch fs {
-		case model.Ext4:
-			fss = NewExt4Service(fsf.RunnerFactory)
-		case model.Xfs:
-			fss = NewXfsService(fsf.RunnerFactory)
-		case model.Unformatted:
-			return nil, fmt.Errorf("🔴 An unsupported filesystem was encountered")
-		}
-		fsf.services[fs] = fss
-	}
-	return fss, nil
+	switch fs {
+	case model.Ext4:
+		return NewExt4Service(fsf.RunnerFactory), nil
+	case model.Xfs:
+		return NewXfsService(fsf.RunnerFactory), nil
+	default:
+		return nil, fmt.Errorf("🔴 An unsupported filesystem was encountered")
+	}
 }
 
 type Ext4Service struct {

internal/utils/exec.go

@@ -37,6 +37,8 @@ func NewExecRunnerFactory() *ExecRunnerFactory {
 	}
 }
 
+// Caching behaviour is implemented for ExecRunnerFactory as we
+// do not need to validate an ExecRunner more than once
 func (rc *ExecRunnerFactory) Select(binary Binary) Runner {
 	r, exists := rc.runners[binary]
 	if !exists {