fix: show amount for bolt12

[reez]

Description

Notes to the reviewers

Changelog notice

Checklists

All Submissions:

• I've signed all my commits
• I have formatted my code with swift-format per .swift-format file

New Features:

• I've added tests for the new feature
• I've added docs for the new feature

Bugfixes:

• This pull request breaks the existing API
• I've added tests to reproduce the issue which are now passing
• I'm linking the issue being fixed by this PR

Summary by CodeRabbit

• New Features

  • Introduced a new Send group for better organization of related components.
  • Enhanced processLightningAddress to accept an additional amount parameter for improved payment scenarios.

• UI Improvements

  • Updated terminology in the UI for clarity (e.g., "Address Sheet" to "Receive Sheet").
  • Replaced custom segmented picker with a standard Picker for better usability in the ReceiveView.

• Bug Fixes

  • Corrected capitalization in text labels for BOLT11 and BOLT12 offers to align with standard conventions.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The project underwent significant restructuring, including the removal of AddressView.swift and AddressViewModel.swift, and the introduction of a new group named Send containing AmountViewModel.swift. The processLightningAddress method was updated to accept an amount parameter, enhancing its functionality. Additionally, UI elements were refined for clarity and consistency, including renaming state variables and modifying displayed text for BOLT specifications.

Changes

Files	Change Summary
LDKNodeMonday.xcodeproj/project.pbxproj	Removed references to AddressView.swift and AddressViewModel.swift; added new group Send with AmountViewModel.swift.
LDKNodeMonday/Extensions/String+Extensions.swift	Updated processLightningAddress method to accept an amount parameter; modified logic to use default amount when processing certain addresses.
LDKNodeMonday/Model/ReceiveOption.swift	Changed label of bolt11JIT from "Bolt11 JIT" to "BOLT11 JIT" for consistency.
LDKNodeMonday/View/Home/BitcoinView.swift	Renamed isAddressSheetPresented to isReceiveSheetPresented to align with functionality.
LDKNodeMonday/View/Home/Receive/BIP21View.swift	Changed text labels from "Bolt 11" to "BOLT 11" and "Bolt 12" to "BOLT12" for consistency in formatting.
LDKNodeMonday/View/Home/Receive/ReceiveView.swift	Replaced custom CustomSegmentedPicker with standard Picker view for option selection, streamlining the code and reducing complexity.
LDKNodeMonday/View/Home/Send/AmountView.swift	Updated displayed text from "Bolt 12 Offer" to "BOLT12 Offer" for proper capitalization.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant BitcoinView
    participant BIP21View
    participant StringExtension

    User->>BitcoinView: Present Receive Sheet
    BitcoinView->>BIP21View: Display BIP21 Options
    User->>BIP21View: Select Option
    BIP21View->>StringExtension: Process Lightning Address with Amount
    StringExtension-->>BIP21View: Return Processed Address
    BIP21View-->>BitcoinView: Update UI with Processed Address

Loading

🐰 In the code we hop and play,
New names and groups lead the way!
With amounts now in sight,
Our functions feel just right.
BOLT12 shines so bright,
Let's code and hop with delight! 🌟

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.