Skip to content

Commit

Permalink
Merge pull request #75 from stefanb/git-submodule-cleanup
Browse files Browse the repository at this point in the history
Cleanup of git submodule leftovers
  • Loading branch information
refaktor authored Dec 22, 2023
2 parents 0b0147f + ce0aa10 commit 412014e
Show file tree
Hide file tree
Showing 5 changed files with 2 additions and 8 deletions.
2 changes: 0 additions & 2 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,6 @@ jobs:

steps:
- uses: actions/checkout@v4
with:
submodules: true

- name: Set up Go
uses: actions/setup-go@v4
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/golangci-lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,6 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
with:
submodules: true

- uses: actions/setup-go@v4
with:
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ jobs:
- uses: actions/checkout@v4
with:
fetch-depth: 0 # needs full git history for changelog generation
submodules: true

- run: git fetch --force --tags

Expand Down
2 changes: 1 addition & 1 deletion contrib/README.md
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
# rye-contrib
repo for contributed, third party or in general less-official bindings and builtin functions. It's a submodule of rye repo.
Packages for contributed, third party or in general less-official bindings and builtin functions.
3 changes: 1 addition & 2 deletions contrib/ebitengine/builtins_ebitengine.go
Original file line number Diff line number Diff line change
Expand Up @@ -82,8 +82,7 @@ func (g *Game) Layout(outsideWidth, outsideHeight int) (screenWidth, screenHeigh
// ## IDEA
// Should move to external repo rye-alterego, which contrary to main Rye, would focus on desktop / UI / game / windows?
// This would make main Rye and Contrib cleaner and focused on the linux backend tasks, information (pre)processing, ...
// It would also serve as a test if we can move contrib to external module instead of it being a git submodule which
// complicates many things.
// It would also serve as a test if we can move contrib to external module instead of it being a simple sub package

var Builtins_ebitengine = map[string]*env.Builtin{

Expand Down

0 comments on commit 412014e

Please sign in to comment.