Implement spreadsheet dump #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rokostik
commented
Nov 5, 2024
Comment on lines
+336
to
+339
| // Fill in missing columns (if they exist) with void (_) | ||
| for i := len(row.Values); i < len(s.Cols); i++ { | ||
| sb.WriteString(" _") | ||
| } |
There was a problem hiding this comment.
I'm not sure if there can be a case where there are less row values than columns. From what I've looked at this can't happen but added it just in case. If it can never happen this can be removed.
There was a problem hiding this comment.
Good call ... better safe than having possible runtime errors later I think.
|
Uh, great! This will get handy real soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements dumping spreadsheets.
All values are converted to rye values (as is the case with
List).