Remove raw spreadsheet rows and support multiple indexes #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rokostik
commented
Dec 14, 2023
| res := AddIndexes(ps, &spr, colWords) | ||
| if res != nil { | ||
| return res | ||
| } | ||
| return spr |
There was a problem hiding this comment.
When adding indexes it doesn't add them in place and you have to reassign the spreadsheet (this was also the behaviour before my changes). I couldn't get it to change in place, any ideas?
There was a problem hiding this comment.
Hm, not right now. I will take note and look at it. Otherwise not changing values in place is sort of default behavior for Rye.
|
Great, thank you!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes 4 things: