Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding list and block functionality for Contains function #89

Merged
merged 3 commits into from
Jan 1, 2024

Conversation

pratikmota
Copy link
Contributor

Changes:

  1. Contains working with Block
  2. Contains working with List
    image
  3. Added test cases
  4. Doubts:
  • After adding test cases for contain if i run ../rye main.rye test , it is not displaying my test case result. (group "contains")
  • Also if we run ../rye main.rye doc > builtins.html , then there are different files are generated also builtins.html is coming blank.
  • Is there any recent changes for test / test case/ document related?

@InvoiceFox
Copy link
Contributor

Hi Pratik! Thank you for your improvements! I redid the tests and documentation because it's separated to multiple files now. The one file of docs was getting too large so it was confusing. I will add your tests to appropriate file. Docs now generate multiple html files, that aren't added to github, but generated on the fly and uploaded.
I also changed so that contrib is now a normal folder, not a submodule any more and there were some other cleaning ups.
Thanks again for you PR!

@refaktor refaktor merged commit 947a573 into refaktor:main Jan 1, 2024
3 checks passed
@pratikmota pratikmota deleted the contains-feature branch January 2, 2024 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants