[1.15.2] Ingots to Blocks, Blocks to Ingots Loop

[BlameMateo]

Issue description:

The auto crafting system creates a loop if you have for instance an Iron Block to Ingots Pattern and Ingots to Iron Block Pattern. I'm using Charcoal in the instance that I first ran into this issue.

What happens:

When requesting an item like Charcoal, where I have a Charcoal to Block recipe and a Block to Charcoal recipe along with a secondary method to make charcoal using oak logs and a furnace, it ends up looping itself and won't use the Log to Charcoal method to create additional charcoal.

What you expected to happen:

I expect it to use another method of creating the resource if I have that available within the storage.

Steps to reproduce:

1. Make 3 Patterns - Ingot to Block, Block to Ingot, and another way to make that Ingot
2. Put patterns in crafters and attempt to auto craft.

Version (make sure you are on the latest version before reporting):

• Minecraft: 1.15.2
• Forge: 31.1.49
• Refined Storage: 1.8.1

Does this issue occur on a server?
Yes

If a (crash)log is relevant for this issue, link it here:

[pastebin/gist/etc link here]

[uecasm]

RS only really keeps track of one active pattern for any single output item, so you should never create more than one pattern with the same output. Avoid creating the Block to Ingot pattern to resolve the loop.

Store your ingots either as ingots or whatever the pre-ingot form is, then the ingot-output and block-output recipes will only be used on demand and you should never run into problems. Don't store blocks (but it's harmless if you have a small number of left-over blocks in storage, they'll get used first).

To improve storage capacity, the standard workaround is to put the ingot into a Compacting Storage Drawer. This effectively keeps the ingots stored as "blocks" but are readily accessible for crafting in both forms. Or alternatively just make big drives.

You will probably still want to create an ingot-to-block pattern if your ingots are only crafted on demand rather than automatically exported, otherwise a recipe that requires blocks won't realise that it needs to craft more ingots.

[raoulvdberge]

Duplicate of #2675