Merge pull request #87 from danielgtaylor/daniel/missing-return

Fix a bug when loading compact refract attributes; bump to 0.12.1
refractproject · Nov 24, 2015 · 4ecb0b8 · 4ecb0b8
2 parents 831ba85 + 7a654f6
commit 4ecb0b8
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,7 @@
+# 0.12.1 - 2015-11-24
+
+- Fix a bug when loading refracted attributes from compact refract.
+
 # 0.12.0 - 2015-11-23
 
 - Provide a way for elements to mark attributes as unrefracted arrays of

diff --git a/lib/primitives/base-element.js b/lib/primitives/base-element.js
@@ -137,7 +137,7 @@ module.exports = function(registry) {
       this.content = tuple[3];
 
       this.convertAttributesToElements(function(attribute) {
-        registry.fromCompactRefract(attribute);
+        return registry.fromCompactRefract(attribute);
       });
 
       if (this.element !== tuple[0]) {

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "minim",
-  "version": "0.12.0",
+  "version": "0.12.1",
   "description": "A library for interacting with JSON through Refract elements",
   "main": "lib/minim.js",
   "scripts": {

diff --git a/test/subclass-test.js b/test/subclass-test.js
@@ -100,5 +100,10 @@ describe('Minim subclasses', function() {
         ]
       }, null]);
     });
+
+    it('should round-trip', function() {
+      const refracted = myElement.toCompactRefract();
+      expect(myElement.fromCompactRefract(refracted).toCompactRefract()).to.deep.equal(refracted);
+    });
   });
 });