Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to create policies with shorter voting periods #135

Open
ryanchristo opened this issue Aug 8, 2023 · 1 comment
Open

Allow users to create policies with shorter voting periods #135

ryanchristo opened this issue Aug 8, 2023 · 1 comment
Labels
dev Engineering task enhancement New feature or request help wanted Extra attention is needed

Comments

@ryanchristo
Copy link
Member

ryanchristo commented Aug 8, 2023

In the current implementation, a user sets the voting period when creating a group policy based on number of days. In some cases a user may want to set a shorter voting period. We should add support for days to be defined in decimals or the ability to change the unit (i.e. days to hours to seconds etc.).

As a side note, this would also improve the testing experience in a local development environment and when reviewing pull requests as I often find myself having to manually update daysToDuration to secondsToDuration.

@wgwz
Copy link
Contributor

wgwz commented Aug 8, 2023

+1 for easier testing! i prefer the second option of being able to change the unit

@ryanchristo ryanchristo added dev Engineering task help wanted Extra attention is needed enhancement New feature or request labels Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev Engineering task enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants