-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does a given normal surface obstruct hyperbolicity? #67
Open
bobbycyiii
wants to merge
33
commits into
regina-normal:6.0_pre
Choose a base branch
from
bobbycyiii:findFault_alt
base: 6.0_pre
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented T^2xI recognition; implemented auxiliary routines to simplify boundary; added unit tests for T^2xI recognition; added Python bindings for T^2xI recognition.
Implemented CMake and CppUnit scaffolding for fault finding; implemented naive separation testing for surfaces.
Fixed the tests for separating surfaces in lens spaces.
Finished implementing tests for `isEssentialSphere` member function of `NormalSurface` class.
Added Python bindings for the member functions `separates`, `isEssentialSphere`, `isEssentialTorus`, `isEssentialKleinBottle`, and `isSolidTorusAnnulus` of the `NormalSurface` class.
Added header info for a missing function in `NormalSurface.h`.
Added unit tests and methods for `isEssentialSphere` member function of `NormalSurface` class.
Implemented tests for `isEssentialKleinBottle` member function of `NormalSurface` class.
Added `isEssentialKleinBottle` function to `NormalSurface` class. This depends upon the `isTorusXInterval` function in the `Triangulation<3>` class.
Add small Seifert fibered spaces to tests for `isEssentialKleinBottle`.
Add `isEssentialTorus` member function to `NormalSurface` class. Add unit tests for `isEssentialTorus`.
`isEssentialSphere` is only correct for connected triangulations with no sphere boundary components. `isEssentialKleinBottle` and `isEssentialTorus` are only correct for connected irreducible boundary-incompressible triangulations.
Make `isEssentialKleinBottle` and `isEssentialTorus` return \c false given a nonseparating compressible K2 (resp. T2).
Add unit tests for the `isSolidTorusAnnulus` member function of the `NormalSurface` class.
Add `separates`, `isEssentialSphere`, `isEssentialKleinBottle`, `isEssentialTorus`, and `isSolidTorusAnnulus` member functions to `NormalSurface` class, with unit tests, Python bindings, and documentation.
Implemented CMake and CppUnit scaffolding for fault finding; implemented naive separation testing for surfaces.
Fixed the tests for separating surfaces in lens spaces.
Finished implementing tests for `isEssentialSphere` member function of `NormalSurface` class.
Added Python bindings for the member functions `separates`, `isEssentialSphere`, `isEssentialTorus`, `isEssentialKleinBottle`, and `isSolidTorusAnnulus` of the `NormalSurface` class.
Added header info for a missing function in `NormalSurface.h`.
Added unit tests and methods for `isEssentialSphere` member function of `NormalSurface` class.
Implemented tests for `isEssentialKleinBottle` member function of `NormalSurface` class.
Added `isEssentialKleinBottle` function to `NormalSurface` class. This depends upon the `isTorusXInterval` function in the `Triangulation<3>` class.
Add small Seifert fibered spaces to tests for `isEssentialKleinBottle`.
Add `isEssentialTorus` member function to `NormalSurface` class. Add unit tests for `isEssentialTorus`.
`isEssentialSphere` is only correct for connected triangulations with no sphere boundary components. `isEssentialKleinBottle` and `isEssentialTorus` are only correct for connected irreducible boundary-incompressible triangulations.
Make `isEssentialKleinBottle` and `isEssentialTorus` return \c false given a nonseparating compressible K2 (resp. T2).
Add unit tests for the `isSolidTorusAnnulus` member function of the `NormalSurface` class.
Add `separates`, `isEssentialSphere`, `isEssentialKleinBottle`, `isEssentialTorus`, and `isSolidTorusAnnulus` member functions to `NormalSurface` class, with unit tests, Python bindings, and documentation.
Add trivial code for `isHyperbolicHaken` and `knowsHyperbolicHaken` member functions of `Triangulation<3>` class. Add Python bindings for these functions.
Apply changes instead to a new branch hyperbolicHaken. This reverts commit ddccccc.
…into findFault_alt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added some tests that determine whether or not a normal surface is an obstruction to hyperbolicity. For instance, essential spheres, Klein bottles, and tori are such obstructions. Also, an annulus that cuts the manifold into solid tori is also such an obstruction.