Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean c+p #1048

Merged
merged 3 commits into from
Nov 5, 2023
Merged

clean c+p #1048

merged 3 commits into from
Nov 5, 2023

Conversation

sbillinge
Copy link
Contributor

  • use is_pending in filter
  • passing tests locally

Copy link

codecov bot commented Nov 5, 2023

Codecov Report

Merging #1048 (66ffd5e) into main (05a000b) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1048      +/-   ##
==========================================
- Coverage   67.92%   67.91%   -0.01%     
==========================================
  Files          76       76              
  Lines        8471     8472       +1     
==========================================
  Hits         5754     5754              
- Misses       2717     2718       +1     
Files Coverage Δ
regolith/schemas.py 100.00% <ø> (ø)
regolith/builders/cpbuilder.py 97.29% <50.00%> (-1.34%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05a000b...66ffd5e. Read the comment docs.

@sbillinge sbillinge merged commit 1471ed7 into regro:main Nov 5, 2023
1 of 3 checks passed
@sbillinge sbillinge deleted the clean_c+p branch November 5, 2023 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant