-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reports #1060
Merged
Merged
reports #1060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sbillinge
commented
Mar 24, 2024
- comments to help readability in dates
- fix pubs with no doi bug
- load_json test
- first cut at schemas broken out into json
- cleaning schemas.json
- black on schemas.json
- replace bools in the json from True to true etc
- commas and global variables mostly fixedin schemas.json
- first try at all errors removed
- black on schemas.json
- Revert "black on schemas.json"
- new functions for unpacking schema
- imports updated to import alloweds and unpack them from the schema file
- black on schemas.py
- version that is almost working
- validation now working with schema read from json file
- patch import of milestone types into test helpers
This reverts commit 11546bc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.